@slnode test please

Released in loopback-workspace@3.38.0.

@bajtos : i just helped someone else for whom ACLs were not working because RoleMapping had principalId as string, not ObjectId. This bug is painful.

Remind me please: why can't we just add this option to the built-in RoleMapping model in loopback core (or do the config in app.js at app boot if a feature flag is required) ?

"options": {
  "strictObjectIDCoercion": true
},

I don't see anything in the PR that actually tests if the connector is mongo before applying this option to model-config.json so i assume it does not harm when using other connectors

@ebarault

Remind me please: why can't we just add this option to the built-in RoleMapping model in loopback core

Backwards compatibility, as usually. See strongloop/loopback#3198 (comment)

strictObjectIDCoercion will also dictate how ID's are written to mongo in the first place. In other words, it can only be enabled for 'fresh' projects, or after a db migration of legacy (string) ID's in existing applications.

You are welcome :)

(or do the config in app.js at app boot if a feature flag is required) ?

I think that's what this pull request is effectively doing in new applications - setting the required feature flag the way how it can/should be set.

Existing applications can apply the same approach - simply modify the RoleMapping section in server/model-config.json to the following:

{
  "RoleMapping": {
    "dataSource": "db",
    "options": {
      "strictObjectIDCoercion": true,
    },
    "public": false
  }
}

I do realise the current situation is unfortunate and I am happy to discuss other/better ways how to solve this problem.

I think ideally we should fix the root cause, which IIRC lies in the way how foreign keys are treated by LoopBack - the type of foreign keys should be changed from any to number, string, or ObjectID depending on what is the database the target model is attached to.

@superkhau was already taking a stab at that issue, but with little success. You can search for "fix ObjectID coercion", here are few issues to get started:

• proposal for long-term: Long term proposal for ObjectId coercion loopback#1874
• short-term fix that was rejected: Add model def objectid support loopbackio/loopback-datasource-juggler#778